Conversation
Contributor
Author
|
Added trace fallback support in the backtesting fetcher (trace_filter -> debug_traceBlockByNumber -> debug_traceTransaction -> direct calls) with explicit logs and RPC stats, plus a new trace support harness script (scripts/backtesting/trace_support_harness.sh). Also added an FFI command debug log in CredibleTestWithBacktesting so users can copy/paste the exact bash invocation for local debugging. |
Contributor
Author
|
Shellcheck run clean. Fixed SC2046/SC2155 warnings in scripts/backtesting/transaction_fetcher.sh (separate declare/assign, quote sleep args). |
czepluch
reviewed
Jan 19, 2026
czepluch
approved these changes
Jan 19, 2026
Contributor
czepluch
left a comment
czepluch
left a comment
There was a problem hiding this comment.
lgtm. did you test that it works on eth mainnet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.