Skip to content

Fix security issues due to unix-dgram #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aminueza wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix security issues due to unix-dgram #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2125d06
update buffer() deprecation
aminueza Mar 22, 2021
3dc0047
update changelog
aminueza Mar 22, 2021
b450631
upgrade npm packages
aminueza Mar 22, 2021
9e54c8e
update package version
aminueza Mar 22, 2021
f70a0fa
update changelog version
aminueza Mar 22, 2021
c180a51
remove package-lock
aminueza Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# CHANGELOG

## v3.0.2

* Upgrade unix-dgram to 2.0.4
* Upgrade mocha to 8.3.2
* Replace deprecated [DEP0005] Buffer() to Buffer.from()

## v2.0.0

* Upgrade unix-dgram to 0.2.3 (josephfrazier)
Expand Down
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,15 @@ var Transport = {
unix_dgram: function(message, severity, callback){
var self = this;
var preambleBuffer = self.composerFunction('', severity);
var formattedMessageBuffer = Buffer.isBuffer(message) ? message : new Buffer(message);
var formattedMessageBuffer = Buffer.isBuffer(message) ? message : new Buffer.from(message);
var chunkSize = 2000 - preambleBuffer.length - 200;
var numChunks = Math.ceil(formattedMessageBuffer.length / chunkSize);

var fragments = [preambleBuffer];
if (numChunks > 1){
for (var i = 0; i < numChunks; i++){
fragments.push(formattedMessageBuffer.slice(i * chunkSize, Math.min(formattedMessageBuffer.length, (i + 1) * chunkSize)),
new Buffer(' [' + (i + 1) + '/' + numChunks + ']', 'ascii'));
new Buffer.from(' [' + (i + 1) + '/' + numChunks + ']', 'ascii'));
}
} else{
fragments.push(formattedMessageBuffer);
Expand Down Expand Up @@ -424,7 +424,7 @@ SysLogger.prototype.assert = function(expression) {
* Compose syslog message
*/
SysLogger.prototype.composeSyslogMessage = function(message, severity) {
return new Buffer('<' + (this.facility * 8 + severity) + '>' +
return new Buffer.from('<' + (this.facility * 8 + severity) + '>' +
this.getDate() + ' ' + this.hostname + ' ' +
this.tag + '[' + process.pid + ']:' + message);
}
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,18 @@
"bugs": {
"url": "http://github.com/phuesler/ain/issues"
},
"license" : "MIT",
"license": "MIT",
"licenses": [
{
"type": "MIT",
"url": "http://github.com/phuesler/ain/master/LICENSE"
}
],
"devDependencies": {
"mocha": "~1.12.0",
"mocha": "^8.3.2",
"chai": "~1.7.2"
},
"optionalDependencies": {
"unix-dgram": "^2.0.2"
"unix-dgram": "^2.0.4"
}
}