Skip to content

Support authorization via .netrc and auth_patterns#1805

Merged
phst merged 1 commit intomasterfrom
netrc
Mar 30, 2026
Merged

Support authorization via .netrc and auth_patterns#1805
phst merged 1 commit intomasterfrom
netrc

Conversation

@phst
Copy link
Copy Markdown
Owner

@phst phst commented Mar 30, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces authentication support for the emacs_repository rule by integrating get_auth from @bazel_tools and adding netrc and auth_patterns attributes. It also updates the Makefile to allow @bazel_tools dependencies and refreshes the copyright year in the build file. Review feedback identifies redundant or fail(...) checks for the urls and integrity attributes, as these are already marked as mandatory in the rule definition.

@phst phst merged commit 06cd57e into master Mar 30, 2026
18 checks passed
@phst phst deleted the netrc branch March 30, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant