Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces specific Emacs 29 and 30 toolchains for Windows x86_64, migrates toolchain dependencies to external repositories, and updates copyright years. The review identifies a critical issue where unsupported compatibility attributes were added to elisp_toolchain definitions, which will cause build errors and must be removed.
phst
force-pushed
the
toolchain
branch
2 times, most recently
from
b600385 to
9ae4174
Compare
Following https://bazel.build/extending/toolchains#toolchain-definitions, we should use separate toolchains for each supported combination of operating system and processor architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://bazel.build/extending/toolchains#toolchain-definitions, we should use separate toolchains for each supported combination of operating system and processor architecture.