fix(CLI): Stuck waiting when using push -w -B #1003
Merged
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a deadlock issue in the CLI's spinner when using push with the -w -B flags (wait mode with batch mode). The spinner was waiting for a channel signal that never came because batch mode was returning early without properly signaling completion.
Changes:
- Refactored spinner logic to use conditional printing instead of early returns
- Added new
NonBatchPrintfunction to centralize batch mode handling - Replaced direct
fmt.Printcalls with batch-aware print functions
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| clients/cli/cmd/internal/spinner/spinner.go | Removed early return for batch mode and replaced fmt.Print calls with print.NonBatchPrint to ensure channel signaling occurs |
| clients/cli/cmd/internal/print/print.go | Added NonBatchPrint function and optimized NonBatchPrintf to avoid nested formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
forelabs
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinner is using a channel to control waiting, batch mode was ignoring this and got stuck in waiting loop.
phrase/phrase-cli#175