Update splittext.go #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More careful insect the font for "character width" for each character (rune) and do not crash if the font does not have a width for the character.
Renaming
|
Could this please be merged and released? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More carefully inspect the font for "character width" for each character (rune) and do not crash if the font does not have a width for the character.
I was receiving this crash on line 28 when the string contained a single right apostrophe:
P.S. I am no expert but as I was looking around the utf8File seemed a reasonable place to look for more widths.
If it cannot find a width for the character it uses a placeholder, using underscore 'cos "wider seemed safer".