Fix handling of additional INI directory files#362
Merged
Conversation
by checking if filenames are an array. Skip not existing dirs on uninstall command PHP_INI_SCAN_DIR may contain a non-existing directory in the list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP_INI_SCAN_DIR may contain a non-existing directory in the list.
This PR fixes handling of additional INI directory filesby checking if filenames are an array.
I personally experienced fatal error because I had this config:
I have removed
herd-lite, but my php config contained a reference to the ~/.config/herd-lite/binThe original issue caused by the export PHP_INI_SCAN_DIR=... in my
~/.zshrc, added by herd-lite and not removed on uninstall (#beyondcode/herd-community#11)