Merged
Conversation
asgrim
approved these changes
Jan 14, 2025
Contributor
|
Thanks @Bellangelo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
The main issue was that while this test was trying to use the
GITHUB_TOKENenvironment variable, the variable was scoped to be used in a specific command only. I moved the env to the top so it can be accessed by all the commands in the step.Furthermore, this line
- run: composer config --global github-oauth.github.com ${{ secrets.GITHUB_TOKEN }}is removed because this is handled by thesetup-phpaction. For references please check https://github.com/shivammathur/setup-php/blob/main/src/scripts/tools/add_tools.sh#L64 and https://github.com/shivammathur/setup-php?tab=readme-ov-file#wrench-tools-support