feat: CI job for building Docker binary-only images#122
Conversation
76493bf to
7eb5264
Compare
7eb5264 to
61e4a07
Compare
777c6d9 to
47de137
Compare
47de137 to
e0c258d
Compare
|
@asgrim Docker build attestation from latest build can be found here. |
TimWolla
left a comment
There was a problem hiding this comment.
I'm still concerned about https://github.com/php/pie/pull/122/files#r1854054535, given that we only make the Phar available as “latest” and as a specific version, not by any “major” / “minor” wildcards.
The workflow steps look fine to me, except for the few remarks I've made.
|
@TimWolla @asgrim tested new release, images have been built correctly, you can see them in the registry. |
460f0c3 to
61ba6a8
Compare
TimWolla
left a comment
There was a problem hiding this comment.
LGTM now. Thanks for your patience with my reviews 😄
|
@TimWolla after @keradus' reviews nothing seems to be annoying 😂. But seriously, thanks for the great feedback, I've learned new things during the process so for me this was added value. I like good code reviews 👍. |

Similar to composer/docker#250 (more info), this PR introduces a CI process for releasing binary-only images for Pie 🥳!
You can see the result here, there is an image in my fork's Package Registry, built here.
Here's how the image looks like (

dive ghcr.io/wirone/php-pie:latest-bin):PS: I decided to not verify GPG signature during build because we can trust our own workflow (we copy PHAR file built in previous stage), but also I had some problems with verification (GPG imported correctly, but verification failed). Users may verify the file on their own, if they want, using attachedSigning was dropped.pie.asc.Fixes #137