Add support for Symfony 8

[longwave]

Drupal depends on php-tuf/composer-stager, and Drupal 12 will require Symfony 8, so in turn this package needs to support it.

Locally I get the same test failures on develop (on PHP 8.3 or 8.4) and this branch (on PHP 8.4):

ERRORS!
Tests: 524, Assertions: 1661, Errors: 17, Failures: 24, Warnings: 7.

[TravisCarden]

Thanks, @longwave. I'll look into this as soon as I can carve out some time.

[TravisCarden]

That should do it, @longwave! Before I merge, should we cut a new major branch and simultaneously add Symfony 8.x support and drop earlier versions? Should we create a new issue to discuss with other stakeholders?

[longwave]

Do we need a new major here? I think adding support for a new Symfony is fine in a minor version; you aren't removing any API.

As a parallel asm89/stack-cors is also a core dependency, they added Symfony 8 support in a new minor: https://github.com/asm89/stack-cors/releases/tag/v2.4.0

[TravisCarden]

I think adding support for a new Symfony is fine in a minor version; you aren't removing any API.

I'm fine with that, as long as everyone who needs to approve the decision approves it. (I don't know who that would be, but I assumed it would require more than two people.)

I'm also wondering about removing support for Symfony 6 & 7, which obviously would need to be a major version change. And if we chose to do that, I wondered if we should do both things at once. I originally just used whatever versions Drupal core used. I haven't yet had to ask what happens when that changes.

[catch56]

I think if it's easy to add support for Symfony 8 that's good to do in a minor. And then dropping Symfony 6/7 support could happen in a new major.

The advantage of this is that it allows sites to update to a version of composer stager that allows Symfony 8, then update to Symfony 8, then update to the major version of composer stager in three different steps if they want/need to for any reason.

[longwave]

Also, do we need to drop support for older Symfony? As we have passing tests and we haven't need to make any code changes to support the latest Symfony, we might as well keep as wide a range of compatibility as we can.

[TravisCarden]

Cool. Well, I'm going to consider three people a consensus 😄 and merge and release this in a minor right now. We can discuss dropping old Symfony versions at a later date.

[TravisCarden]

It's all yours! 🙂