Fix: force the use of colors when the '--colors' flag is supplied.#190
Open
esthezia wants to merge 2 commits intophp-parallel-lint:developfrom
Open
Fix: force the use of colors when the '--colors' flag is supplied.#190esthezia wants to merge 2 commits intophp-parallel-lint:developfrom
esthezia wants to merge 2 commits intophp-parallel-lint:developfrom
Conversation
Fix: force the use of colors when the '--colors' flag is supplied.
Collaborator
|
@esthezia Thank you for your interest in contributing to this repo. Would you mind adding a test covering the change to this PR ? |
Author
|
Unfortunately, I'm not able to do that. Can you, please, help me with this piece? Thank you! |
Collaborator
@esthezia What information do you need to allow you to add the test(s) ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
php-parallel-lintcommand is ran as a subcommand, and the--colorsflag is used, it is not honoured. This fixes this, and allows for coloured output when forced.