GH Actions: change PHAR building to reusable workflow#185
Merged
Conversation
Collaborator
Author
|
Note: the branch protection will need a small update for the changed job name. |
jrfnl
force-pushed
the
feature/ghactions-split-off-phar-building
branch
from
09e6ada to
4c61b75
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jrfnl
force-pushed
the
feature/ghactions-split-off-phar-building
branch
from
4c61b75 to
c630168
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jrfnl
force-pushed
the
feature/ghactions-split-off-phar-building
branch
from
c630168 to
a486187
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jrfnl
force-pushed
the
feature/ghactions-split-off-phar-building
branch
from
a486187 to
312baf6
Compare
20 tasks
The workflows currently contain two jobs which build the PHAR files. This means that any changes to the steps in these jobs have to be made in two places. With this in mind, it makes sense to change the PHAR building to a reusable workflow, which can then be used by both jobs. With this change, any changes to the steps of the job will only need to be made in one place. This commit makes it so.
jrfnl
force-pushed
the
feature/ghactions-split-off-phar-building
branch
from
312baf6 to
5bd7853
Compare
Collaborator
Author
|
Rebased to solve merge conflicts. No functional changes. |
Collaborator
Author
|
As this PR has been open for six months now and it's only a maintenance/CI change, I'm taking the liberty to merge this without review. |
theofidry
reviewed
Mar 6, 2026
| # Note: do NOT turn on the requirement checker in the box config as it is no longer | ||
| # compatible with PHP < 7.2. | ||
| - name: Install Box | ||
| run: wget https://github.com/box-project/box/releases/latest/download/box.phar -O box.phar && chmod 0755 box.phar && pwd |
There was a problem hiding this comment.
side-note: might be worth caching it.
You could check https://github.com/box-project/box/releases/latest for which the header location gives the tag (e.g. https://github.com/box-project/box/releases/tag/4.6.10) and use that version as the cache key
Collaborator
Author
There was a problem hiding this comment.
@theofidry Good point! I'll open an issue as a reminder to look into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflows currently contain two jobs which build the PHAR files. This means that any changes to the steps in these jobs have to be made in two places.
With this in mind, it makes sense to change the PHAR building to a reusable workflow, which can then be used by both jobs. With this change, any changes to the steps of the job will only need to be made in one place.
This commit makes it so.