fix: Improve annotations of PromiseInterface for psalm#5
Merged
roxblnfk merged 1 commit intophp-internal:2.xfrom Oct 24, 2025
Merged
fix: Improve annotations of PromiseInterface for psalm#5roxblnfk merged 1 commit intophp-internal:2.xfrom
roxblnfk merged 1 commit intophp-internal:2.xfrom
Conversation
roxblnfk
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The list of annotations for
PromiseInterfacehas been expanded for a better understanding of psalm.Why?
The annotations specified in
PromiseInterfacedo not work correctly for psalm:https://psalm.dev/r/491dc2f14a
If you add the
@psalm-yieldannotation, which is supported by psalm, the problem disappears:https://psalm.dev/r/5048107af6
Checklist