UI simplification component implementation #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced reusable components (ModernSearchBarComponent, GenericListComponent, FloatingActionButtonComponent, RecipeListItemComponent, IngredientListItemComponent) to eliminate code duplication in RecipesPage and IngredientsPage. Updated both pages to use these components, significantly reducing code size and improving maintainability. Added documentation describing the new components and their usage.
Merged RecipeListItemComponent and IngredientListItemComponent into a single UniversalListItemComponent with a configurable ShowSubtitle property. Updated RecipesPage and IngredientsPage to use the new component, removed the old components and their code-behind files, and revised documentation to reflect the unified approach. This reduces code duplication, simplifies maintenance, and increases flexibility for future list item types.
Extended UniversalListItemComponent to support Recipe, Ingredient, and Plan modes via new bindable properties (ShowNutritionLayout, ShowPlanLayout, ShowDeleteButton, ShowArchiveButton, ArchiveCommand). Refactored RecipesPage, IngredientsPage, and ShoppingListPage to use the enhanced component, eliminating duplicated list item layouts and enabling flexible configuration for each data type. Updated documentation to reflect the new multi-mode architecture and usage patterns.
Replaces the custom archive list UI in ArchivePage.xaml with the reusable UniversalListItemComponent and GenericListComponent. Adds support for a restore button to UniversalListItemComponent, including new bindable properties and layout changes to accommodate the restore action. This improves code reuse and consistency across list item displays.
Added new localized resources for button texts and titles related to adding, editing, and saving recipes and ingredients. Updated AddRecipeViewModel and IngredientFormViewModel to use these localized strings instead of hardcoded values, improving internationalization support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to localization and code reusability in the Foodbook application. The main changes include adding new localized button texts for both English and Polish, updating view models to use these resources, and refactoring the
ArchivePageto leverage new reusable UI components.Localization enhancements:
ButtonResources.resx(English) andButtonResources.pl-PL.resx(Polish). [1] [2]ButtonResources.Designer.csto expose the new localization strings as static properties. [1] [2]View model updates:
AddRecipeViewModelandIngredientFormViewModelto use the new localized button texts for titles and button labels, replacing hardcoded strings. [1] [2]UI componentization and refactoring:
FloatingActionButtonComponent.xaml,GenericListComponent.xaml,IngredientListItemComponent.xaml,ModernSearchBarComponent.xaml,RecipeListItemComponent.xaml, andUniversalListItemComponent.xaml, enabling more modular and reusable UI elements.ArchivePage.xamlto use the newGenericListComponentandUniversalListItemComponentfor displaying archived plans, replacing the previous inlineCollectionViewand item template. This improves maintainability and consistency across the app.