-
Notifications
You must be signed in to change notification settings - Fork 0
Add Shell routes and unify item card layout in pages #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added explicit Route properties to all ShellContent tabs in AppShell.xaml for improved navigation. Updated IngredientsPage and RecipesPage to use Frame instead of Border for item cards, added tap gesture recognizers for editing, and aligned their layouts for consistency with PlannerPage.
Refactored AppShell navigation by removing custom OnNavigating logic and updating the Home tab route. Expanded and corrected the ingredients.json dataset: added new items (e.g., different types of milk, potatoes, rice, tofu, and yogurts), updated nutritional values, renamed some entries for clarity, and removed several redundant or less relevant items.
Updated AddRecipePage, ArchivePage, ShoppingListDetailPage, and ShoppingListPage to use Frame instead of Border for item templates. This change improves compatibility and visual consistency across the app's UI components.
Enhanced double and integer parsing in AddRecipeViewModel and IngredientFormViewModel to handle both comma and dot as decimal separators, improving user input flexibility. Added helper methods for validation and parsing, and updated PlannerPage to always reload recipes on subsequent loads to reflect new additions.
Replaced basic StackLayouts with styled Frame containers for input fields in AddRecipePage.xaml, ArchivePage.xaml, and IngredientFormPage.xaml. Enhanced visual consistency and accessibility by applying app theme bindings for colors, rounded corners, and font sizes. Updated empty view and item templates in ArchivePage for better appearance in light and dark modes.
Changed 'Description' labels and placeholders to 'Instructions' in both English and Polish resource files for clarity. Updated AddRecipePage editor to use dynamic height instead of fixed height and removed redundant styling. Removed recipe description preview from RecipesPage for a cleaner UI.
|
This pull request introduces several improvements and updates across the application, focusing on ingredient data accuracy, localization, and input validation. The most significant changes include refining the ingredient database for better specificity, improving localization and labeling, and enhancing input handling for numeric fields. Ingredient Database Refinement:
Localization and UI Label Improvements:
Input Validation and Parsing Enhancements:
ViewModel and Service Integration:
These updates collectively improve data quality, user experience, and input reliability throughout the application. |
Added explicit Route properties to all ShellContent tabs in AppShell.xaml for improved navigation. Updated IngredientsPage and RecipesPage to use Frame instead of Border for item cards, added tap gesture recognizers for editing, and aligned their layouts for consistency with PlannerPage.