Skip to content

trunner: support loading files via blob#469

Draft
damianloew wants to merge 2 commits intomasterfrom
damianloew/trunner_loading_files
Draft

trunner: support loading files via blob#469
damianloew wants to merge 2 commits intomasterfrom
damianloew/trunner_loading_files

Conversation

@damianloew
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@damianloew damianloew changed the title Damianloew/trunner loading files trunner: support loading files via blob Mar 26, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the ability to load raw binary blobs into the syspage using the PLO bootloader, complementing the existing application loading functionality. The AppLoader harnesses have been renamed to SyspageLoader to reflect this expanded scope, with corresponding updates to the configuration parser, test runner, and target-specific loading logic for GDB, pyocd, and phoenixd. A review comment notes that a comment in psh/test.yaml regarding excluded targets may now be outdated or confusing given the removals from that list.

load:
- file: /etc/shells
targets:
# To be included after adding PloSyspageLoader on this platform

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment "# To be included after adding PloSyspageLoader on this platform" seems to be outdated. The targets listed below this comment have been removed from the exclude list, implying they are now included because PloSyspageLoader has been added. Consider updating or removing this comment for clarity.

@github-actions
Copy link

Unit Test Results

10 461 tests  +2   9 796 ✅  - 1   54m 23s ⏱️ + 2m 51s
   629 suites +4     662 💤 ±0 
     1 files   ±0       3 ❌ +3 

For more details on these failures, see this check.

Results for commit 8bf1380. ± Comparison against base commit f7978fc.

This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libtrace/test-libtrace ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libtrace/test-libtrace.test_libtrace.test_libtrace_err
phoenix-rtos-tests/libtrace/test-libtrace ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libtrace/test-libtrace.test_libtrace.test_libtrace_record
phoenix-rtos-tests/libtrace/test-libtrace ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libtrace/test-libtrace.test_libtrace.test_libtrace_start_stop
phoenix-rtos-tests/libtrace/test-libtrace ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libtrace/test-libtrace
phoenix-rtos-tests/psh/cat-shells ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/psh/cat-shells
phoenix-rtos-tests/psh/cat-shells ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/psh/cat-shells
phoenix-rtos-tests/psh/cat-shells ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/psh/cat-shells
phoenix-rtos-tests/psh/cat-shells ‑ armv7r5f-zynqmp-qemu:phoenix-rtos-tests/psh/cat-shells

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant