Conversation
JIRA: CI-659
JIRA: CI-659
There was a problem hiding this comment.
Code Review
This pull request implements the ability to load raw binary blobs into the syspage using the PLO bootloader, complementing the existing application loading functionality. The AppLoader harnesses have been renamed to SyspageLoader to reflect this expanded scope, with corresponding updates to the configuration parser, test runner, and target-specific loading logic for GDB, pyocd, and phoenixd. A review comment notes that a comment in psh/test.yaml regarding excluded targets may now be outdated or confusing given the removals from that list.
| load: | ||
| - file: /etc/shells | ||
| targets: | ||
| # To be included after adding PloSyspageLoader on this platform |
There was a problem hiding this comment.
The comment "# To be included after adding PloSyspageLoader on this platform" seems to be outdated. The targets listed below this comment have been removed from the exclude list, implying they are now included because PloSyspageLoader has been added. Consider updating or removing this comment for clarity.
Unit Test Results10 461 tests +2 9 796 ✅ - 1 54m 23s ⏱️ + 2m 51s For more details on these failures, see this check. Results for commit 8bf1380. ± Comparison against base commit f7978fc. This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both. |
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment