lsb_vsx: adjust timeouts

[mateusz-bloch]

Description

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: (add PR link here).
• Tested by hand on: (list targets here).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• I will merge this PR by myself when appropriate.

[gemini-code-assist]

Summary of Changes

Hello @mateusz-bloch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the test infrastructure by completely removing the Coremark Pro test suite, which appears to be no longer needed or maintained. Concurrently, it optimizes the execution of the lsb_vsx test by adjusting a critical timeout value, aiming for faster and more efficient test runs.

Highlights

• Coremark Pro Test Suite Removal: The entire Coremark Pro test suite, including its Python harness, YAML configuration, and timeout definitions, has been removed from the project.
• LSB VSX Test Timeout Adjustment: The dut.expect timeout in the lsb_vsx.py test harness has been significantly reduced from 2000 seconds to 90 seconds, along with the addition of a debug print statement.

Changelog

• coremark_pro/coremark_pro.py
  • Removed the Python harness for the Coremark Pro test suite.
• coremark_pro/test_coremark_pro.yaml
  • Removed the YAML configuration file defining the Coremark Pro tests.
• coremark_pro/timeouts.yaml
  • Removed the YAML file containing timeout definitions for Coremark Pro benchmarks.
• lsb_vsx/lsb_vsx.py
  • Updated the dut.expect timeout from 2000 to 90 seconds.
  • Added a print(idx) statement for debugging purposes.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/ci.yml

Activity

• No specific activity (comments, reviews, etc.) was found in the provided context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request primarily involves the removal of Coremark Pro test files and a modification to the lsb_vsx.py harness. The changes in lsb_vsx.py include a significant reduction in the dut.expect timeout and the addition of a debug print statement. The reduction in timeout should be carefully validated to ensure it doesn't introduce flakiness, and the debug print statement should be removed.

[gemini-code-assist]

The timeout for dut.expect has been reduced from 2000 seconds to 90 seconds. While 2000 seconds might be excessive, a drastic reduction to 90 seconds could lead to test failures if the DUT takes longer to respond under certain conditions (e.g., heavy load, slower hardware, or complex test cases). Please ensure this new timeout is sufficient for all expected scenarios and is based on empirical data rather than an arbitrary reduction. If the previous timeout was too long, consider a more robust timeout mechanism or a value that accounts for variability.

Suggested change

	idx = dut.expect([start, tc_start, status, tc_end, final, msg_line, vsx_error], timeout=90)
	idx = dut.expect([start, tc_start, status, tc_end, final, msg_line, vsx_error], timeout=2000)

[gemini-code-assist]

This print statement appears to be for debugging purposes. It should be removed before merging to avoid polluting standard output, which can interfere with automated test parsing or logging infrastructure.

[github-actions]

Unit Test Results

     1 files  ±     0   2 158 suites  +1 575   6h 1m 37s ⏱️ + 5h 9m 16s
24 465 tests +14 940  20 592 ✅ +11 659  3 872 💤 +3 280  1 ❌ +1 
24 651 runs  +15 126  20 739 ✅ +11 806  3 911 💤 +3 319  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 14a0ef2. ± Comparison against base commit 048bb6e.

♻️ This comment has been updated with latest results.