Skip to content

psh: add terminal control codes test#312

Open
maska989 wants to merge 2 commits intomasterfrom
maska989/psh_control
Open

psh: add terminal control codes test#312
maska989 wants to merge 2 commits intomasterfrom
maska989/psh_control

Conversation

@maska989
Copy link
Contributor

@maska989 maska989 commented Jan 19, 2024 •
edited
Loading

Description

JIRA: CI-397

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a7-imx6ull-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

mateusz-bloch
mateusz-bloch reviewed Jan 23, 2024
View reviewed changes
psh/test-control.py
Comment on lines +49 to +50
@psh.run
def harness(p):
Copy link
Member

@mateusz-bloch mateusz-bloch Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering whether to organize the tests in a uniform manner, for example, in relation to the CONTROL CODE CHEAT SHEET, and whether to expand the tests from basic ones that test a given control code, to tests that use several, and up to those that use as many as possible. It would be beneficial if the combinations reflected real-world scenarios. So, then you could also divide the tests into separate functions (?)

Copy link
Contributor Author

@maska989 maska989 Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is just to check that this control codes works, doesn't need to test them with full possibility use set.

@maska989 maska989 force-pushed the maska989/psh_control branch 2 times, most recently from d8ba5ca to 01345a4 Compare January 26, 2024 11:55
mateusz-bloch
mateusz-bloch reviewed Jan 29, 2024
View reviewed changes
@maska989 maska989 force-pushed the maska989/psh_control branch 2 times, most recently from 0ef59b3 to c4c686e Compare January 30, 2024 13:54
@maska989 maska989 marked this pull request as ready for review January 30, 2024 13:59
@maska989 maska989 force-pushed the maska989/psh_control branch from c4c686e to 4061065 Compare February 2, 2024 08:32
@maska989 maska989 requested a review from damianloew April 26, 2024 12:18
@maska989 maska989 force-pushed the maska989/psh_control branch from 4061065 to 865eb37 Compare April 29, 2024 10:03
@maska989 maska989 requested a review from mateusz-bloch August 12, 2024 07:30
@maska989 maska989 force-pushed the maska989/psh_control branch from 865eb37 to ae3958c Compare July 21, 2025 11:46
@maska989 maska989 force-pushed the maska989/psh_control branch from ae3958c to c213850 Compare September 26, 2025 12:12
@github-actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

Unit Test Results

8 442 tests   - 991   7 918 ✅  - 926   42m 4s ⏱️ - 7m 24s
  496 suites  -  49     524 💤  -  65 
    1 files   ±  0       0 ❌ ±  0 

Results for commit de178e1. ± Comparison against base commit f646ce7.

This pull request removes 1000 and adds 9 tests. Note that renamed tests count towards both. 
flash ‑ aarch64a53-zynqmp-qemu:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
…

phoenix-rtos-tests/psh/control-codes ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ ia32-generic-qemu:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ riscv64-generic-qemu:phoenix-rtos-tests/psh/control-codes
phoenix-rtos-tests/psh/control-codes ‑ sparcv8leon-generic-qemu:phoenix-rtos-tests/psh/control-codes

♻️ This comment has been updated with latest results.

@maska989 maska989 force-pushed the maska989/psh_control branch 2 times, most recently from 4eeaf60 to b369a37 Compare October 13, 2025 12:24
@maska989 maska989 force-pushed the maska989/psh_control branch from b369a37 to de178e1 Compare October 17, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damianloew damianloew Awaiting requested review from damianloew

@mateusz-bloch mateusz-bloch Awaiting requested review from mateusz-bloch

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maska989 @mateusz-bloch