libc: enable testcases requiring tini

[adamdebek]

JIRA: CI-365

Description

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: (add PR link here).
• Tested by hand on: (list targets here).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• I will merge this PR by myself when appropriate.

[github-actions]

Unit Test Results

9 462 tests  +29   8 873 ✅ +26   49m 45s ⏱️ - 1m 38s
  561 suites ± 0     585 💤 ± 0 
    1 files   ± 0       4 ❌ + 3 

For more details on these failures, see this check.

Results for commit dbf63a4. ± Comparison against base commit bf20f74.

This pull request removes 1 and adds 30 tests. Note that renamed tests count towards both.

phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit

phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.stdlib_exit.atexit_few_calls
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.stdlib_exit.atexit_register_inside
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.stdlib_exit.atexit_two_nodes
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.stdlib_exit.stream_flush
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.unistd_Exit.SIGCHLD_sent
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.unistd_Exit.chk_if_exits
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.unistd_Exit.close_streams
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.unistd_Exit.exit_status_waitpid
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.unistd_Exit.new_parent_id
phoenix-rtos-tests/libc/exit ‑ aarch64a53-zynqmp-qemu:phoenix-rtos-tests/libc/exit.unistd_Exit.no_atexit
…

♻️ This comment has been updated with latest results.

[damianloew]

LGTM

[nalajcie]

wouldn't it break running these tests on host outside of docker?

[adamdebek]

It should not, I checked it anyway.

[nalajcie]

It should not, I checked it anyway.

It's broken on my host (I don't have tini installed):

(killed by a signal in the middle of testing)

[nalajcie]

It should not, I checked it anyway.

(killed by a signal in the middle of testing)

seems to be killed by SIGPIPE on line 589, not sure if related to tini as I don't see signal handler for SIGPIPE anywhere.

[damianloew]

It should not, I checked it anyway.

(killed by a signal in the middle of testing)

seems to be killed by SIGPIPE on line 589, not sure if related to tini as I don't see signal handler for SIGPIPE anywhere.

I also see this problem now, it seems to be not related with tini and orphaned child ad has to be solved (I'd suggest the separate PR). However I see some other issue related to this topic:

Because of such code some cases are skipped when running on host without tini:

	/* Check if tini is available */
	if (access(TEST_TINI_PATH, F_OK) != 0) {
		TEST_IGNORE_MESSAGE("Lack of init system in docker container");
	}

[adamdebek]

It should not, I checked it anyway.

(killed by a signal in the middle of testing)

seems to be killed by SIGPIPE on line 589, not sure if related to tini as I don't see signal handler for SIGPIPE anywhere.

Yea, it is related to this issue: phoenix-rtos/phoenix-rtos-project#733
On host SIGPIPE is sent and it causes process to terminate, it didn't show up while using runner because runner ignores SIGPIPE and probably exit-test inherited this signal disposition.

[nalajcie]

maybe we should set default signal handlers in trunner just before running the test?