Use action-suggester instead of a patched reviewdog#433
Draft
Use action-suggester instead of a patched reviewdog#433
Conversation
Remove clang-format from the "push" event. Annotations do not support suggestions, so there is no sense to apply clang-format directly to commits. Use action-suggester instead of a patched reviewdog. JIRA: CI-123
nalajcie
reviewed
Jun 22, 2022
Member
nalajcie
left a comment
nalajcie
left a comment
There was a problem hiding this comment.
lets assume checking formatting on direct-commit is a non-issue.
Suggesting some small enhancements to implement.
| REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| git diff -U0 HEAD^ | clang-format-diff-10 -p1 | /tmp/reviewdog -f=diff -f.diff.strip=0 -name=clang-format-pr -reporter=github-pr-review -fail-on-error | ||
| - run: git diff -U0 HEAD^ | clang-format-diff-10 -p1 | patch -p0 |
Member
There was a problem hiding this comment.
- please name this step
- IMHO using
clang-format-diff -iwould be more straightforward instead of pipe'ing it topatch - maybe comment how it works (we won't be parsing the tool output, the changes are applied to the code and analyzed in the next step)
|
|
||
| jobs: | ||
| clang-format: | ||
| if: github.event_name == 'push' |
Member
There was a problem hiding this comment.
removed only job run on push, You can adjust the global on properties and remove if in the jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove clang-format from the "push" event. Annotations
do not support suggestions, so there is no sense to apply
clang-format directly to commits.
Use action-suggester instead of a patched reviewdog.
poc phoenix-rtos/phoenix-rtos-tests#116
Types of changes
How Has This Been Tested?
Checklist:
Special treatment