posix_open: propagate error from posix_create

[lukileczo]

YT: RTOS-1268

Description

Motivation and Context

Return more meaningful info about why open failed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: (add PR link here).
• Tested by hand on: (list targets here).

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• I will merge this PR by myself when appropriate.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the error reporting mechanism within the posix_open function. By directly propagating the error code from posix_create, the system can provide more precise and meaningful information about why a file opening operation failed, especially when it involves creating a new file. This change improves diagnostic capabilities and allows for more targeted error handling by callers.

Highlights

• Error Propagation: The posix_open function now correctly propagates the specific error code returned by posix_create when a file creation attempt fails, instead of always returning a generic -EIO.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the error handling within the posix_open function in posix/posix.c. Previously, if posix_create failed, a generic -EIO error was assigned. The change now directly propagates the specific error code returned by posix_create, improving the granularity and accuracy of error reporting. There is no feedback to provide as no review comments were submitted.

[github-actions]

Unit Test Results

9 553 tests  +8 123   8 961 ✅ +8 104   52m 55s ⏱️ + 46m 3s
  591 suites +    8     592 💤 +  518 
    1 files   ±    0       0 ❌  -   499 

Results for commit 0bec655. ± Comparison against base commit cbfa5d0.