Open
Conversation
added 3 commits
March 17, 2025 17:46
JIRA: RTOS-927
JIRA: RTOS-927
JIRA: RTOS-927
648e079 to
7de8546
Compare
JIRA: RTOS-962
7de8546 to
69832cb
Compare
nalajcie
reviewed
Mar 24, 2025
Member
nalajcie
left a comment
There was a problem hiding this comment.
looks ok, I'm just making sure I understand how it will work now
69832cb to
a36c3d3
Compare
nalajcie
previously approved these changes
Mar 24, 2025
a36c3d3 to
f97b037
Compare
| +PHOENIX_OPTS += /fPIC/mfdpic | ||
| + | ||
| +# Finally, add Phoenix options to RM multilibs. | ||
| +# Keep the orignal requires because of kernel and plo. |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
orignal ==> original
| @@ -1,13 +0,0 @@ | ||
| -# PhoenixRTOS uses relocatable ELFs on NOMMU platforms | ||
| -# if this is ARM Cortex-M/R subvariant -> build libgcc/crtstuff with PIC | ||
| -# ALSO: ensure data is not interwined with .text, otherwise running XIP programs would fail |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
interwined ==> intertwined
Unit Test Results7 010 tests - 948 6 551 ✅ - 883 34m 42s ⏱️ - 5m 57s Results for commit 4f880dc. ± Comparison against base commit 06a6db3. This pull request removes 948 tests.♻️ This comment has been updated with latest results. |
4136223 to
d7694dd
Compare
JIRA: RTOS-1028
d7694dd to
4f880dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-1028
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
Makefile: adapt to being build as a multilib phoenix-rtos-kernel#641
arm: adapt to being built as multilib libphoenix#409