fix: proxy auth signing and project root resolution#367
Merged
Conversation
Contributor
Cairn Quality ReportCommit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filters.tagsis unsetRoot cause
The hardening patch only signed timestamp/remote/path, so trusted identity headers could be changed after signing, and the new shared secret was not wired into environment-driven provider setup. The project-root validation also overconstrained explicit absolute paths used by child processes and CI. Separately, hook filter tag matching used negated boolean logic that incorrectly rejected events when
filters.tagswasNone.Validation
Closes #338
Closes #339
Closes #344