This repository was archived by the owner on Jan 23, 2019. It is now read-only.
Use 'use_inline_resources' to ensure notifications propagate correctly #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR phlipper#69 updated the monit provider to use run_action on the provided resources to make external notifications propagate (i.e., so that a 'notifies' in a monit_monitrc's block would run). But that has the side effect of not firing the 'notifies' inside the monit_monitrc resource, and thus monit never reloads when a new monit_monitrc resource is created. This use use_inline_resources to evaluate the monit template in its own context, so that that context will fire notifications declared on the monit_monitrc resource, while still firing the notification on the template itself. See notes on updated_by_last_action here: https://docs.chef.io/custom_resources_notes.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #69 updated the monit provider to use
run_actionon the provided resources to make external notifications propagate (i.e., so that a 'notifies' in amonit_monitrc's block would run). But that has the side effect of not firing the 'notifies' inside themonit_monitrcresource, and thus monit never reloads when a newmonit_monitrcresource is created.This uses
use_inline_resourcesto evaluate the monit template in its own context, so that that context will fire notifications declared on themonit_monitrcresource, while still firing the notification on the template itself.Tested against Chef 12.14.68, 12.21.1 (current) , 13.1.31 (current).