Skip to content

libbase: Updates bison minimum version to 3.8.2, having the fix for the now-removed extra compile flag. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phkaeser wants to merge 2 commits into
base: main
Choose a base branch
from
Open

libbase: Updates bison minimum version to 3.8.2, having the fix for the now-removed extra compile flag. #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f9395
libbase: Updates bison minimum version to 3.8.2, having the fix for t…
phkaeser Oct 2, 2025
1805186
FIXME: bump bsd.
phkaeser Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-for-bsd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build for Free BSD 14.2
name: Build for Free BSD 14.3

on:
push:
Expand All @@ -19,7 +19,7 @@ jobs:
uses: cross-platform-actions/action@v0.26.0
with:
operating_system: freebsd
version: '14.2'
version: '14.3'
run: |
sudo sed -i '' 's/quarterly/latest/' /etc/pkg/FreeBSD.conf
sudo pkg install -y \
Expand Down
7 changes: 3 additions & 4 deletions src/plist/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ FLEX_TARGET(
${CMAKE_CURRENT_BINARY_DIR}/analyzer.c
DEFINES_FILE ${CMAKE_CURRENT_BINARY_DIR}/analyzer.h)

FIND_PACKAGE(BISON 3.0 REQUIRED)
# Needs 3.8.2 due to a build warning.
# See: https://github.com/phkaeser/wlmaker/issues/53
FIND_PACKAGE(BISON 3.8.2 REQUIRED)
BISON_TARGET(
grammar
grammar.y
Expand Down Expand Up @@ -47,9 +49,6 @@ TARGET_INCLUDE_DIRECTORIES(
PUBLIC
${CMAKE_CURRENT_BINARY_DIR}/)

# TODO(kaeser@gubbe.ch):Remove, once updating post bison 3.8.2 (Aug 2022).
# See: https://github.com/phkaeser/wlmaker/issues/53
TARGET_COMPILE_OPTIONS(libbase_plist PRIVATE -Wno-unused-but-set-variable)
TARGET_LINK_LIBRARIES(libbase_plist libbase)
SET_TARGET_PROPERTIES(
libbase_plist
Expand Down
Loading