Open
Conversation
…nRead entries into owned buffers and yield safe AsyncRead via SyncIoBridge to avoid lifetime hacks.
…std::env::set_var early in single-threaded setup to avoid UB and improve robustness.
…ontextual errors for piped IO; capture stderr and check exit codes for ffmpeg/ffprobe.
…ail splits and parsing safely; extract raw body via match to avoid panics.
…ure stderr and validate piped IO in rga.rs and custom adapters; replace expects with contextual errors.
…xt on metadata.modified() for robust error reporting.
…duplicate versions; no API changes expected for current usage.
…prove throughput for large files during preprocessing.
…rga-zip-extensions and --rga-ffmpeg-extensions; apply overrides in get_adapters_filtered using AdapterOverride wrapper.
…he parsed RGA_CONFIG for preproc; avoid repeated env JSON parsing.
Author
Performance
|
…rides in preproc\n\nFix manifest duplication and update get_adapters_filtered call to pass config for overrides.
…\nAdd zip_extensions and ffmpeg_extensions examples to default config; tests verify overrides applied to metadata.
…ible versions to allow latest stable patches: anyhow 1.0, regex 1, serde_json 1.0, env_logger 0.10, log 0.4.
…topt provides required CLI; removing clap v4 reduces duplication in cargo tree.
…bility\n\nFix unresolved imports and async_zip API mismatch; keep features consistent.
… RGA_CONFIG propagation to process env\n\nReplace SyncIoBridge with StreamReader over Bytes; set RGA_CONFIG via Command.env to avoid unsafe env mutation.
…e reader()\n\nStore filename and sizes before taking mutable reader to satisfy borrow checker.
…der and pass PATH via Command.env\n\nIntroduce compute_exe_path() returning PATH value; use RUST_LOG through logger builder and avoid global env set.
…rap subprocess stdout and postproc streams to replace \r\n with \n for platform-agnostic outputs.
…th clap::Parser, update attributes and parse/command calls; remove structopt dep and add clap v4.
…alue_t for typed defaults and import CommandFactory for command() usage.
…remove unused builder
…reduce duplicates
…mpression algorithm features\n\nFix compression level type; remove unused clap imports.
… on stable. Accept benign Windows ecosystem duplicates in cargo tree -d for now.
Author
Dependency upgrades and CLI migration
|
…Switch to clap v4 parsing; pass-through params integrated for list, preview, and fzf.
…\n\nAdd --rga-postproc-binary-marker, --rga-postproc-page-prefix, and --rga-postproc-page-include-empty; wire into postproc adapters.
… with use<T> in postproc_pagebreaks
…ts to use new signature
…ait lifetime captures
…output wait\n\nWrap evince and open operations with contextual errors; improve fzf wait error context.
…ig\n\nAdd CLI flags and config keys with examples; clarify that overrides replace defaults and impact pre-glob.
Author
Adapter extension overrides
FZF integration flags
Post-processing configuration
Documentation
|
Replace unwrap with error propagation via anyhow::Context; no runtime panics.
Make lazy_static FROM_REGEX a Result<Regex> and use FROM_REGEX.as_ref()? at call site to avoid runtime panics.
Author
|
- Add config_hash method to RgaConfig that hashes relevant configuration fields - Include file modification time in cache key for real files - Pass file_mtime_unix_ms through AdaptInfo chain for consistent caching - Add safety limit for zip file memory pre-allocation (10MB max) - Adjust buffer sizes based on accurate mode to reduce memory usage
…ecomputation The loop_adapt function and related helpers now accept an active_adapters parameter, which is passed through recursive calls instead of recomputing the adapter list each time. This eliminates redundant work when processing nested archives. - Modify choose_adapter to optionally accept precomputed active adapters - Update buf_choose_adapter and loop_adapt to propagate active adapters - Adjust caching logic to use provided adapters - Simplify zip adapter by extracting make_zip_adapt_info helper - Update all test calls to pass get_all_adapters result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::env::set_varexecuted before spawning threads.unwrap/expect/panic!in non-test code with?and contextualanyhowerrors.rg,ffprobe,ffmpeg, custom binaries):