Skip to content

Add support for cargo binstall#236

Open
yodatak wants to merge 1 commit intophiresky:masterfrom
yodatak:patch-1
Open

Add support for cargo binstall#236
yodatak wants to merge 1 commit intophiresky:masterfrom
yodatak:patch-1

Conversation

@yodatak
Copy link
Copy Markdown

@yodatak yodatak commented Jul 17, 2024

Hello i think it work i try with the command and it seem to works

cargo binstall --pkg-url="{ repo }/releases/download/{ version }/{ name }-{ version }-{ target }.{ archive-format }"--pkg-fmt="txz"  ripgrep_all

Hello i think it work i try with the command and it seem to works

cargo binstall --pkg-url="{ repo }/releases/download/{ version }/{ name }-{ version }-{ target }.{ archive-format }"--pkg-fmt="txz"  ripgrep_all
Comment on lines +74 to +76
[package.metadata.binstall]
pkg-url = "{ repo }/releases/download/{ version }/{ name }-{ version }-{ target }.{ archive-format }"
pkg-fmt = "tgz"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yodatak Have you tried running binstall without these lines? Based on my reading of the binstall docs it seems like this configuration is all covered by binstall's defaults…

@phiresky
Copy link
Copy Markdown
Owner

phiresky commented Oct 8, 2024

tbh I'm not sure whether we should "support" cargo install or this even, because we can not ship "dependencies" then, and rga is significantly less useful when you don't have pdftotext etc installed. For "advanced" users it's fine, but I don't really want more questions of the type "why does it not work for pdfs".

rg and afaik many other rust programs does not support cargo install as an official install method for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants