Replace EasyHttp with RestSharp#17
Conversation
Also removed AmountInDecimal from ProcessPaymentRequest. I don't think the api wrapper should try to handle currency corrections. User should know what the Spreedly currency unit is for their case.
Also fix build error in PaymentModule
|
Just realized that I didn't redo the serialization on the domain. Maybe we need to use the default Xml libraries instead of RestSharp's implementation. |
|
These 2 PR's are interesting. I should get time soon to run these through several projects unit tests and integration tests to try and spot any issues with the swap over. Are you using this in a project that is live? Or are you desperately waiting on updated nuget packages :) |
|
I'm working on a new features for an existing project that we are converting to Spreedly. Nothing live yet. I'm gonna see if I can modify these PRs to use System.Xml.Serialization instead of RestSharp.Serialize as you've got a lot of attribute mapping which could be hard to convert to RestSharp. |
|
Yeh. I wanted clean C#, hence the attributes. The original names from the spreedly API aren't very C# friendly with underscores etc. Is there not something similar in RestSharp? |
|
Yes, but only with one attribute: Regardless, I've created a All tests are passing, and I've confirmed I can create and redact gateways using the web sample. I haven't tested payments on the sample yet as I have to configure a public site to test it on. |
|
Just tested payments and they are working too. |
Also update request names to verbs
This is ugly, but I don't know of a better work around except IXmlSerializable
There is no extra dependency on Json in RestSharp.
Breaking Change: removed AmountInDecimal from ProcessPaymentRequest.