-
Notifications
You must be signed in to change notification settings - Fork 39
Removed "Error" #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed "Error" #84
Conversation
Remove "Error", The "return" already implies an error. Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context.
Remove "Error", The "return" already implies an error. Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context.
|
This error is visible to the user in its bare form, so I would rather keep the "Error" prefix. |
|
How about this? or |
|
We could make a small improvement by aligning it with the naming scheme from here, as those would also be user visible: |
|
as example of prefix: |
|
While I like prefixes in general for logging or debugging (like in long running server applications), I wouldn’t put any of these kinds of prefixes on user visible errors. I don’t see many cli tools having prefixes in their error messages. User visible errors should be as human readable and understandable as possible, like a regular English sentence. |
|
I got it. So, then I suggest, fix only the small letter at the beginning. |
|
LGTM |
The "return" already implies an error.
Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context.