Skip to content

Bugfix/yt dlp update #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElFishi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/yt dlp update #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a810d8f
Update README to latest version of yt-dlp-update feature
ElFishi Mar 3, 2026
e45a287
make error parsing less specific
ElFishi Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 56 additions & 40 deletions README_update_feature.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,45 +219,60 @@ Win32::Process::Create(

```javascript
[% IF update_in_progress %]
var pollInterval = setInterval(function() {
var xhr = new XMLHttpRequest();
xhr.open('GET', window.location.href + '&t=' + Date.now(), true);
xhr.onload = function() {
var doc = new DOMParser().parseFromString(this.responseText, "text/html");
var newStatus = doc.getElementById('update_status_message');
var currentStatus = document.getElementById('update_status_message');

if (newStatus && currentStatus) {
currentStatus.innerHTML = newStatus.innerHTML;

// Check if still running
var isRunning = newStatus.innerHTML.indexOf('status-running') !== -1 ||
newStatus.innerHTML.indexOf('[% "PLUGIN_YOUTUBE_UPDATING" | string %]') !== -1;

if (!isRunning) {
clearInterval(pollInterval);
document.documentElement.classList.remove('wait');

// Update version number
var newVersion = doc.getElementById('ytdlp_current_version');
var currentVersion = document.getElementById('ytdlp_current_version');
if (newVersion && currentVersion) {
currentVersion.innerHTML = newVersion.innerHTML;
}

// Re-enable button
var btn = document.querySelector('input[name="update_ytdlp"]');
if (btn) {
btn.disabled = false;
btn.style.cursor = '';
btn.value = "[% 'PLUGIN_YOUTUBE_UPDATE_YTDLP' | string %]";
(function() {
document.documentElement.classList.add('wait');
var isPolling = false;

var pollInterval = setInterval(function() {
if (isPolling) return; // Skip if previous request is still out
isPolling = true;
var xhr = new XMLHttpRequest();
var url = window.location.href;
var separator = url.indexOf('?') !== -1 ? '&' : '?';
xhr.open('GET', url + separator + 't=' + new Date().getTime(), true);

xhr.onload = function() {
isPolling = false; // Reset flag
if (this.status >= 200 && this.status < 400) {
var parser = new DOMParser();
var doc = parser.parseFromString(this.responseText, "text/html");

var newStatus = doc.getElementById('update_status_message');
var currentStatus = document.getElementById('update_status_message');

if (newStatus && currentStatus) {
currentStatus.innerHTML = newStatus.innerHTML;

// Check if still running
var isRunning = newStatus.innerHTML.indexOf('status-running') !== -1 ||
newStatus.innerHTML.indexOf('[% "PLUGIN_YOUTUBE_UPDATING" | string %]') !== -1;

if (!isRunning) {
document.documentElement.classList.remove('wait');
clearInterval(pollInterval);

// Update version number
var newVersion = doc.getElementById('ytdlp_current_version');
var currentVersion = document.getElementById('ytdlp_current_version');
if (newVersion && currentVersion) {
currentVersion.innerHTML = newVersion.innerHTML;
}

// Re-enable button
var btn = document.querySelector('input[name="update_ytdlp"]');
if (btn) {
btn.disabled = false;
btn.style.cursor = '';
btn.value = "[% 'PLUGIN_YOUTUBE_UPDATE_YTDLP' | string %]";
}
}
}
}
}
};
xhr.onerror = function() { isPolling = false; };
xhr.send();
}, 2000);
};
xhr.onerror = function() { isPolling = false; };
xhr.send();
}, 2000);
})();
[% END %]
```

Expand Down Expand Up @@ -370,7 +385,7 @@ Strings available in 4 languages (CS, DA, DE, EN):
- `PLUGIN_YOUTUBE_AUTO_UPDATE` - "Automatic Updates"
- `PLUGIN_YOUTUBE_AUTO_UPDATE_DESC` - "Automatically check for and install yt-dlp updates daily"
- `PLUGIN_YOUTUBE_ENABLE_AUTO_UPDATE` - "Enable automatic daily updates"
- `PLUGIN_YOUTUBE_AUTO_UPDATE_HOUR` - "Update check time"
- `PLUGIN_YOUTUBE_AUTO_UPDATE_HOUR` - "Update time"
- `PLUGIN_YOUTUBE_LAST_AUTO_UPDATE` - "Last automatic update"
- `NOT_AVAILABLE` - "N/A"

Expand Down Expand Up @@ -404,10 +419,10 @@ Strings available in 4 languages (CS, DA, DE, EN):
- `plugins/YouTube/Plugin.pm` - Plugin initialization with auto-update support via new module
- `plugins/YouTube/strings.txt` - Localized strings for new features


### Renamed Files (case change)
- `plugin/bin/*` → `plugin/Bin/*` - Standardized directory name capitalization


## Performance Considerations

### Version Caching
Expand Down Expand Up @@ -509,4 +524,5 @@ Strings available in 4 languages (CS, DA, DE, EN):
5. **Temp file cleanup**: May leave temp files on abrupt process termination
6. **Time drift**: Server time changes may affect scheduled updates
7. **Single binary**: Only one binary can be auto-updated at a time
8. **Pathes unprotected**: Single(double)-quote escaping is the only protection for binary path
8. **Pathes unprotected**: Single(double)-quote escaping is the only protection for binary path

4 changes: 2 additions & 2 deletions plugin/Update_yt_dlp.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ sub _handleYtDlpUpdateResult {
}

# exit code not conclusive
if ((defined $exit_code && $exit_code != 0) || $output =~ /(?:permission\s+denied|fatal\s+error|cannot\s+update|not\s+found|no\s+such\s+file)/i) {
if ((defined $exit_code && $exit_code != 0) || $output =~ /(?:permission\s+denied|cannot\s+update|not\s+found|no\s+such\s+file|error)/i) {
$output =~ s/\s+$//;
$status = (Slim::Utils::Strings::string('PLUGIN_YOUTUBE_UPDATE_FAILED') || 'Update failed') . ": " . ($output || "Unknown error");
$error = 1;
Expand Down Expand Up @@ -450,4 +450,4 @@ sub _handleYtDlpUpdateResult {
$cache->set('yt:update_in_progress', 0, 300);
}

1;
1;