Skip to content

Fix ubuntu segfault #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shawnpg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ubuntu segfault #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8e16d2
Fix segfault on Ubuntu caused by passing NULL to strtok
shawnpg Dec 19, 2018
b374234
Fix whitespace
shawnpg Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/bam_filt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ int parse_target_list(bam_hdr_t *header){
if(header->n_targets == 0) {
fprintf(stderr, "WARNING : no sequences in bam header : in : %s\n", __func__);
}

// strtok will cause a seg fault if you giv it a NULL at least for Unbuntu
if(bamfilt_global_opts.exclude_str == NULL) return 0;

char * pch = strtok (bamfilt_global_opts.exclude_str,",");
uint32_t nseq = 0;
while (pch != NULL)
Expand Down