Skip to content

Add support for popup notifications with --notify.#85

Merged
arithmetric merged 3 commits intomasterfrom
feature/84/notifications
Dec 31, 2014
Merged

Add support for popup notifications with --notify.#85
arithmetric merged 3 commits intomasterfrom
feature/84/notifications

Conversation

@grayside
Copy link
Contributor

Fixes #84

Happy Holidays.

@grayside grayside added this to the 0.5.0 milestone Dec 25, 2014
@arithmetric
Copy link
Collaborator

This is great!

One request: Could we add a Gruntconfig.json setting to enable this by default (rather than requiring the command-line option)?

@grayside
Copy link
Contributor Author

I thought it would be annoying for some tasks, like help. I looked for a way to check the currently running task and configure that by default and had trouble.

The current implementation is using the hook/event system to automatically fire, I'll see if there's a way to whitelist.

If that fails we can configure custom notifications for long tasks and disable automatic success notifications.

I'm not sure what happens on headless systems, I expect it's a noop.

@grayside
Copy link
Contributor Author

I'll start with a bonus option, configurable execution time after which to use the message. This was a killer piece in how drush notify came together.

@arithmetric
Copy link
Collaborator

👍

@grayside
Copy link
Contributor Author

Had to fork grunt-notify to do it (dylang/grunt-notify#89) but the last idea is now working. Changes in the latest commit:

  • --notify is dropped. --quiet is added.
  • GRUNT_DRUPAL_QUIET environment variable added, same as quiet.
  • Switched a fork of grunt-notify.
  • Added threshold concept, notifications that are triggered before the process.uptime() is less than a certain number of seconds will be suppressed.
  • Added new Gruntconfig parameter to managed this for GDT with 10 second default.

@arithmetric arithmetric force-pushed the feature/84/notifications branch from 6937b40 to 430f272 Compare December 31, 2014 05:23
arithmetric added a commit that referenced this pull request Dec 31, 2014
Add support for popup notifications with --notify.
@arithmetric arithmetric merged commit 3e23fd0 into master Dec 31, 2014
@arithmetric arithmetric deleted the feature/84/notifications branch December 31, 2014 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to for popup notifications

2 participants