fix: turn on errors so vignette builds #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
Author
NNNOOOOOOOOOO!!!!!!! we went below 90%!!!! |
Collaborator
Author
|
Going to merge in to see what madness happens!! |
Collaborator
|
literally just pulled this up to merge it when I watched it magically merge itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put error = TRUE in the markdown chunks for the lockfile vignette.
This feels like something with how things are compiled?? As the vignette builds locally for me, but in the packagedown call it falls over.
Could we output the lock file and store it with how we do the adsl, riskdiff, etc log files?? this way it isn't executing every time we build the website. not ideal as we will miss stuff but at least it builds?!?!?!