-
Notifications
You must be signed in to change notification settings - Fork 9
Fixes #229, #186, #228 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…te log element descriptions
|
@bms63 @nicholas-masel @parmsam-pfizer this should be it for random documentation updates. I don't know how much more we want to say in these but I'm happy to update things if anyone sees any part that is still lacking. I can't run off logs on my current setup so I wanted to see if someone else could rerun the logs we have in the data-raw folder and then copy them in to \vignettes\articles once this is through. Once these are built I can do a final release PR to main and build for CRAN! |
|
@parmsam-pfizer any ideas - is it working on your end? |
|
That's odd. Same here. I'll look into this further to see what's going on. It knits to HTML without issues but has an error reading the log when I run it manually chunk by chunk. |
|
@kodesiba I rerun all the |
|
let me know if you need any other help |
|
Related to the sessioninfo update. It seems to have messed up a convention I was using to nest/subnest the log. Looking into a fix now. |
|
@bms63, should work now. Just tested it on my machine. |
|
I think the script should be exposed in the vignette - i set echo = TRUE |
|
Yeah, that's normal. It comes from Lines 194 to 200 in cc2b597
|
|
Could we merge to main and see if it publishes. if it doesn't then we should fix this. my build is not building the RMD file unless I set
─ Packages ─────────────────────────────────────────────────────────────────────────────────────── [1] /cloud/lib/x86_64-pc-linux-gnu-library/4.2
|
|
@bms63 happy to merge this to main if we want to see what happens |
|
@bms63 since you know what section needs to be updated in the vignette can you add the error = true part, the run looks to have failed |




Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the logrx codebase remains robust and consistent.
The spirit of logrx
While many packages to facilitate the logging of code already exist in the R ecosystem, it is hard to find a solution that works well for clinical programming applications. Many logging implementations are more implicit and rely on user input to create the log for the execution of a script. While this is useful for logging specific events of an application, in clinical programming a log has a set purpose.
logrx is built around the concept of creating a log for the execution of an R script that provides an overview of what happened as well as the environment that it happened in. We set out to create a flexible logging utility that could provide the necessary information to anyone reviewing the code execution so they can recreate the execution environment and run the code for themselves. Please make sure your Pull Request meets this spirit of logrx.
Please check off each taskbox as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devbranch until you have checked off each task.log_remove().devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelypkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.R CMD checklocally and address all errors and warnings -devtools::check()