Closes #117 Update for ignore_seconds_flag

[jeffreyad]

Pull Request

DESCRIPTION GOES HERE

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

• Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
• Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
• First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
• Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
• Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
• New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
• Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
• Testing Instructions: Provide instructions on how to test the code if necessary.

[Copilot]

Pull Request Overview

This pull request adds the ignore_seconds_flag = FALSE parameter to derive_vars_dtm() function calls in pharmacokinetic analysis scripts to address issue #117.

Key Changes:

• Added explicit ignore_seconds_flag = FALSE parameter to PC data derivation calls in ADPC and ADPPK datasets
• Added trailing blank lines to R script files for better formatting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
adam/adpc.R	Added ignore_seconds_flag = FALSE to PC date derivation and trailing blank line
adam/adpc.qmd	Added ignore_seconds_flag = FALSE to PC date derivation in Quarto document
adam/adppk.R	Added ignore_seconds_flag = FALSE to PC date derivation and trailing blank line
adam/adppk.qmd	Added ignore_seconds_flag = FALSE to PC date derivation in Quarto document

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The ignore_seconds_flag = FALSE parameter is added to the derive_vars_dtm() call for PC data, but the same parameter is not added to the derive_vars_dtm() calls for EX data (lines 132-135 and 137-140). For consistency, consider adding ignore_seconds_flag = FALSE to all derive_vars_dtm() calls in this file, or provide a comment explaining why only the PC data derivation requires this parameter.

[Copilot]

The ignore_seconds_flag = FALSE parameter is added to the derive_vars_dtm() call for PC data, but the same parameter is not added to the derive_vars_dtm() calls for EX data (lines 81-84 and 86-89). For consistency, consider adding ignore_seconds_flag = FALSE to all derive_vars_dtm() calls in this file, or provide a comment explaining why only the PC data derivation requires this parameter.

[Copilot]

The ignore_seconds_flag = FALSE parameter is added to the derive_vars_dtm() call for PC data, but the same parameter is not added to the derive_vars_dtm() calls for EX data (lines 136-139 and 141-144). For consistency, consider adding ignore_seconds_flag = FALSE to all derive_vars_dtm() calls in this file, or provide a comment explaining why only the PC data derivation requires this parameter.

[Copilot]

The ignore_seconds_flag = FALSE parameter is added to the derive_vars_dtm() call for PC data, but the same parameter is not added to the derive_vars_dtm() calls for EX data (lines 76-79 and 81-84). For consistency, consider adding ignore_seconds_flag = FALSE to all derive_vars_dtm() calls in this file, or provide a comment explaining why only the PC data derivation requires this parameter.

[bms63]

oh - we don't need to do anything with EX right?

[jeffreyad]

Right, but only because I know EX doesn't have seconds, but PC does