-
Notifications
You must be signed in to change notification settings - Fork 17
close #105 adding slides and docx #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation and examples for generating presentation slides and Word documents in the pharmaverse context. It demonstrates workflows for creating digital outputs using rtables.officer for Word documents and autoslider.core for PowerPoint presentations.
- Adds Word document generation example using rtables.officer with clinical trial data
- Adds presentation slide generation example using autoslider.core framework
- Updates package dependencies to include required libraries for document generation
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| documents/index.qmd | Creates main index page for digital files documentation section |
| documents/docx.qmd | Comprehensive example of generating Word documents with clinical tables using rtables.officer |
| documents/autoslider.qmd | Complete workflow example for automated slide generation using autoslider.core |
| DESCRIPTION | Adds new package dependencies (autoslider.core, filters, rtables, rtables.officer) and contributor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @shajoezhu are you able to pull upstream changes? This might trigger the spelling and styling checks recently added. |
Hi @jeffreyad , sure, I will do a rebase! thanks for the headsup |
|
I can take a look - maybe once the cycle with @rossfarrugia is completed. I can give it a once-over?? I will be in the same bin as a new user. @StefanThoma maybe we could bring you in - I think you have familiarity with these packages?? |
StefanThoma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, very familiar actually ;)
Does it run?
I agree with Ross's comments.
Co-authored-by: Ross Farrugia <82581364+rossfarrugia@users.noreply.github.com>
|
I was able to render the page, however I see warning messages such as the following: |
Thanks @jeffreyad , yes, these were expected. I have submitted the latest package to cran, and it wil cover these fixes |
|
@shajoezhu i left a few more minor comment replies above. given some others have had chance to take a look now as well, then once you resolve those i'm happy to get this one approved and merged. thanks for all the efforts!! Also reminder to add anyone else who contributed to writing these articles to our |
rossfarrugia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Joe - will approve and merge and if anyone spots any other updates from now feel free to make new issues/MRs
|
Congrats all!! What a great addition to the examples site!! |
Pull Request
DESCRIPTION GOES HERE
Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!
Closes #<insert_issue_number>at the beginning of your PR title. Use the Edit button in the top-right if you need to update.DESCRIPTIONfile.DESCRIPTIONfile'sImportssection.