Skip to content

Conversation

@shajoezhu
Copy link
Collaborator

@shajoezhu shajoezhu commented Aug 18, 2025

Pull Request

DESCRIPTION GOES HERE

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

  • Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.

@shajoezhu shajoezhu changed the title [draft] adding slides and docx close #105 adding slides and docx Aug 18, 2025
@shajoezhu shajoezhu linked an issue Aug 18, 2025 that may be closed by this pull request

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@shajoezhu shajoezhu requested a review from Copilot August 18, 2025 21:10

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@shajoezhu shajoezhu requested a review from Copilot August 18, 2025 21:15

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@shajoezhu shajoezhu requested a review from Copilot August 18, 2025 22:42

This comment was marked as outdated.

@shajoezhu shajoezhu requested a review from Copilot August 19, 2025 00:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation and examples for generating presentation slides and Word documents in the pharmaverse context. It demonstrates workflows for creating digital outputs using rtables.officer for Word documents and autoslider.core for PowerPoint presentations.

  • Adds Word document generation example using rtables.officer with clinical trial data
  • Adds presentation slide generation example using autoslider.core framework
  • Updates package dependencies to include required libraries for document generation

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 5 comments.

File Description
documents/index.qmd Creates main index page for digital files documentation section
documents/docx.qmd Comprehensive example of generating Word documents with clinical tables using rtables.officer
documents/autoslider.qmd Complete workflow example for automated slide generation using autoslider.core
DESCRIPTION Adds new package dependencies (autoslider.core, filters, rtables, rtables.officer) and contributor

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jeffreyad
Copy link
Collaborator

Hi @shajoezhu are you able to pull upstream changes? This might trigger the spelling and styling checks recently added.

@shajoezhu
Copy link
Collaborator Author

Hi @shajoezhu are you able to pull upstream changes? This might trigger the spelling and styling checks recently added.

Hi @jeffreyad , sure, I will do a rebase! thanks for the headsup

@bms63
Copy link
Collaborator

bms63 commented Sep 19, 2025

I can take a look - maybe once the cycle with @rossfarrugia is completed. I can give it a once-over?? I will be in the same bin as a new user. @StefanThoma maybe we could bring you in - I think you have familiarity with these packages??

Copy link

@StefanThoma StefanThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, very familiar actually ;)
Does it run?
I agree with Ross's comments.

@jeffreyad
Copy link
Collaborator

I was able to render the page, however I see warning messages such as the following:

Warning in (function (x, layout = NULL, master = NULL, ..., .dots = NULL) : Calling `add_slide()` without specifying a `layout` is deprecated.
 Please pass a `layout` or use `layout_default()` to set a default.
 => I will now continue with the former `layout` default "Title and Content" for backwards compatibility...```

@shajoezhu
Copy link
Collaborator Author

I was able to render the page, however I see warning messages such as the following:

Warning in (function (x, layout = NULL, master = NULL, ..., .dots = NULL) : Calling `add_slide()` without specifying a `layout` is deprecated.
 Please pass a `layout` or use `layout_default()` to set a default.
 => I will now continue with the former `layout` default "Title and Content" for backwards compatibility...```

Thanks @jeffreyad , yes, these were expected. I have submitted the latest package to cran, and it wil cover these fixes

@rossfarrugia
Copy link
Contributor

@shajoezhu i left a few more minor comment replies above. given some others have had chance to take a look now as well, then once you resolve those i'm happy to get this one approved and merged. thanks for all the efforts!!

Also reminder to add anyone else who contributed to writing these articles to our DESCRIPTION file, as saw in the original commit there were other authors listed for each article.

Copy link
Contributor

@rossfarrugia rossfarrugia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Joe - will approve and merge and if anyone spots any other updates from now feel free to make new issues/MRs

@rossfarrugia rossfarrugia merged commit c2ea09e into pharmaverse:main Sep 25, 2025
5 checks passed
@bms63
Copy link
Collaborator

bms63 commented Sep 25, 2025

Congrats all!! What a great addition to the examples site!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Documents section and example

5 participants