replacing data to pharmaverse data #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayogasekaram
changed the title
ayogasekaram
reviewed
Nov 4, 2025
Collaborator
ayogasekaram
left a comment
ayogasekaram
left a comment
There was a problem hiding this comment.
Thank you so much for working on this @harsha047676! Just had a few comments - let me know if I can help :)
Merge branch 'feature_change_to_pharmaverse_data' of github.com:pharmaverse/cardinal into feature_change_to_pharmaverse_data # Conflicts: # quarto/catalog/fda-table_13/index.qmd # quarto/catalog/fda-table_14/index.qmd
…averse/cardinal into feature_change_to_pharmaverse_data
ayogasekaram
reviewed
Nov 5, 2025
…averse/cardinal into feature_change_to_pharmaverse_data
…e snapshot for table 14
Collaborator
|
Hey @jknizia, just adding you as a reviewer as I pushed a few things to this PR so I think a second look would be helpful. I can add a different reviewer if you don't have the bandwidth :) |
Collaborator
|
Hi @ayogasekaram, thank you so much for adding me. I would be happy to review, but, frankly speaking, I am swamped with tasks for the next couple of weeks. If you would like to get a review rather sooner, you might want to add another reviewer. Sorry! |
edelarua
approved these changes
Nov 19, 2025
Collaborator
edelarua
left a comment
edelarua
left a comment
There was a problem hiding this comment.
Thanks @ayogasekaram and @harsha047676! This should be good to go now!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
GitHub Issue
Closes #318