-
Notifications
You must be signed in to change notification settings - Fork 16
closes #338 docorator blog post #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manciniedoardo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post! Just some minor formatting comments to ease publishing.
bms63
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaehmann FYI @chrisprice-phuse needs to approve each blog post before publishing. he is super quick.
something to add to the PR template and README #309
| # library(link) | ||
| # link::auto() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manciniedoardo these are commented out so the link package won't make the auto-links for packages and functions anymore.
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
|
@manciniedoardo thank you for the review - I just made some edits accordingly. Please let me know if any other changes are needed! |
|
@bzkrouse can you style your code and add any spelling exemptions to the inst/WORDLIST.txt file. You can use the R/CICD.R file for spelling. don't worry about links. if the code and spelling style fail for other files don't worry about them |
|
@bms63 done!! please let me know if anything else is needed :) |
Thank you for your Pull Request! We have developed this task checklist to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your blog post.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task."posts/zzz_DO_NOT_EDIT_<your post title>". This is so that the post date can be auto-updated upon the merge intomain.CICD.Rline by line to first check the spelling in your post and then to make sure your code is compatible with our code-style. Address any incongruences by following the instructions in the file!tag(s)or categories from the current list:c("Metadata", "SDTM", "ADaM", "TLG", "Shiny", "Python", "Community", "Conferences", "Submissions", "Technical", "DEI")for your blog post. If you cannot find anything that fits your blog post, propose a new tag to the maintainers! Note: if you use a tag not from this list, the "Check Post Tags" CICD pipeline will error. We occasionally tidy up alltagsfor consistency.descriptionfield at the top of the markdown document.This blog contains opinions that are of the authors alone and do not necessarily reflect the strategy of their respective organizations.)