Skip to content

Conversation

@jimrothstein
Copy link

This is VERSION 2

ADMH,OCCDS,SMQ02SC,SMQ 02 Scope,admiral,derive_vars_query,https://pharmaverse.github.io/admiral/cran-release/reference/derive_vars_query.html,Template Example,https://github.com/pharmaverse/admiral/blob/main/inst/templates/ad_admh.R
ADMH,OCCDS,SMQ02SCN,SMQ 02 Scope (N),admiral,derive_vars_query,https://pharmaverse.github.io/admiral/cran-release/reference/derive_vars_query.html,Template Example,https://github.com/pharmaverse/admiral/blob/main/inst/templates/ad_admh.R
ADMH,OCCDS,CQ04NAM,Customized Query 04 Name,admiral,derive_vars_query,https://pharmaverse.github.io/admiral/cran-release/reference/derive_vars_query.html,Template Example,https://github.com/pharmaverse/admiral/blob/main/inst/templates/ad_admh.R
ADMH,OCCDS,CQ04CD,Customized Query 04 Code,admiral,derive_vars_query,https://pharmaverse.github.io/admiral/cran-release/reference/derive_vars_query.html,Template Example,https://github.com/pharmaverse/admiral/blob/main/inst/templates/ad_admh.R
ADVS,BDS,"PARAMCD=""WSTCIR""",Derive Waist to Height Ratio,admiralmetabolic,derive_param_waisthgt,https://pharmaverse.github.io/admiralmetabolic/reference/derive_param_waisthgt.html,Template Example,https://github.com/pharmaverse/admiralmetabolic/blob/main/vignettes/advs.Rmd
ADVS,BDS,"PARAMCD=""WSTHIP""",Derive Waist to Hip Ratio,admiralmetabolic,derive_param_waisthip,https://pharmaverse.github.io/admiralmetabolic/reference/derive_param_waisthip.html,Template Example,https://github.com/pharmaverse/admiralmetabolic/blob/main/vignettes/advs.Rmd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we may have lost an entry, right? Do you know why that occured?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which 'entry' is missing?? I can grep the last 2.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the original file have 426 rows and the updated 425, or this is just a funny git diff numbering thing?

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it; let me check now -
Please see file inst/lookup.diff , uses diffdf::diffdf looks like 424 rows

@jimrothstein
Copy link
Author

@ddsjoberg
Hope this is better (VERSION 2)

@jimrothstein
Copy link
Author

@ddsjoberg
Downloaded RAW file directly from this repo.
It is 424 x 9
read_csv(file.path("inst", "admiral-lookup-book-RAW-copy.csv"))

@jimrothstein
Copy link
Author

@ddsjoberg
Are we ok with 424 records? Should I try to check earlier commits??

@jimrothstein
Copy link
Author

@ddsjoberg Are we ok with 424 records? Should I try to check earlier commits??

If I missed your reply, apologies. I am ok with 424 rows because this is directly from package itself.
Should I try to fix the failing checks ?

@jimrothstein jimrothstein closed this by deleting the head repository Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants