Skip to content

Closes #68 update urls in the csv #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bms63 merged 4 commits into from
Jun 27, 2025
Merged

Closes #68 update urls in the csv #69

bms63 merged 4 commits into from
Jun 27, 2025

Conversation

@bms63
Copy link
Contributor

@bms63 bms63 commented Jun 27, 2025

No description provided.

@bms63 bms63 linked an issue Jun 27, 2025 that may be closed by this pull request
Update URLs in the CSV #68
Closed
@bms63
Copy link
Contributor Author

bms63 commented Jun 27, 2025

I was thinking about a link checker for admiraldiscovery? This one does the bare minimum but I want more!! Not sure how to check them in the csv files that is used, but be nice to grab any dead links and remove them (thinking functions that are deprecated or something happens like with cran-release thing)

@bms63 bms63 requested a review from ddsjoberg June 27, 2025 18:19
ddsjoberg
ddsjoberg reviewed Jun 27, 2025
View reviewed changes
.github/workflows/common.yaml Outdated
@@ -0,0 +1,125 @@
---
Copy link
Collaborator

@ddsjoberg ddsjoberg Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this in a separate PR where we can discuss and not hold up the URL corrections?

Copy link
Contributor Author

@bms63 bms63 Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes np!

ddsjoberg
ddsjoberg requested changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Can you bump the version number with usethis::use_dev_version() and add a NEWS entry?

@bms63
Copy link
Contributor Author

bms63 commented Jun 27, 2025

Looks great!

Can you bump the version number with usethis::use_dev_version() and add a NEWS entry?

You want it as 0.4.1 or 0.5.0?

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Jun 27, 2025

You want it as 0.4.1 or 0.5.0?

As 0.4.0.9000. That usethis function should do it automatically in description and in NEWS

ddsjoberg
ddsjoberg approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺🏼 great!

@bms63 bms63 merged commit d5e6f20 into main Jun 27, 2025
3 checks passed
@ddsjoberg ddsjoberg deleted the 68-update-urls-in-the-csv branch June 27, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddsjoberg ddsjoberg ddsjoberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update URLs in the CSV

3 participants

@bms63 @ddsjoberg