Closes #2929 feature request add function to derive nfrlt #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…rder in NAMESPACE Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…variables Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…e-insensitive Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…r/hours, m/min/minute/minutes) Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…HR" or "3 HR") Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…erns without Post-dose Co-authored-by: jeffreyad <112705781+jeffreyad@users.noreply.github.com>
…ding derive_extreme_records.Rd
merge copilot/add-pctpt-to-hours-function # Conflicts: # NEWS.md
bms63
reviewed
Jan 6, 2026
R/convert_xxtpt_to_hours.R
Outdated
| #' **Special Cases:** | ||
| #' * `"Screening"` → 0 | ||
| #' * `"Pre-dose"`, `"Predose"`, `"Pre-treatment"`, `"Pre-infusion"`, | ||
| #' `"Pre-inf"`, `"Before"`, `"Infusion"`, `"0H"` → 0 |
Collaborator
There was a problem hiding this comment.
→
I am weary of this character. I don't think it is allowed by CRAN. Do we use other places or do other packages use it?
bms63
reviewed
Jan 6, 2026
| @@ -0,0 +1,501 @@ | |||
| #' Derive Nominal Relative Time from First Dose (NFRLT) | |||
| #' | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| #' | |
| #' | |
| #' @description | |
| #' `r lifecycle::badge("experimental")` |
We will define what this means soon - should be pretty close to the experimental in https://lifecycle.r-lib.org/articles/stages.html#experimental
bms63
reviewed
Jan 6, 2026
| @@ -0,0 +1,876 @@ | |||
| #' Convert `XXTPT` Strings to Hours | |||
| #' | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| #' | |
| #' | |
| #' @description | |
| #' `r lifecycle::badge("experimental")` |
Collaborator
|
Thanks again @jeffreyad and @Kcdahn !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
mainbranch until you have checked off each task.styler::style_file()to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptxand re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdunder the header# admiral (development version)if the changes pertain to a user-facing function (i.e. it has an@exporttag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.mdfor tracking developer-facing issues.pkgdown::build_site()and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()