Skip to content

Conversation

@llrs-roche
Copy link
Collaborator

@llrs-roche llrs-roche commented Sep 18, 2025

Related to pharmaR/pharmapkgs#58

  • No test done on old R versions: I don't have them installed at this moment

@llrs-roche llrs-roche marked this pull request as ready for review October 2, 2025 11:34
@llrs-roche
Copy link
Collaborator Author

Lowering to R 4.3 works with some warnings and notes (but doesn't fail checks).
To test it try to install this package on R 4.3.0

@Zhenglei-BCS
Copy link
Collaborator

Lowering to R 4.3 works with some warnings and notes (but doesn't fail checks). To test it try to install this package on R 4.3.0

I can test that.

@llrs-roche
Copy link
Collaborator Author

@Zhenglei-BCS Thanks, let me know if it works and then I'll merge this PR

@Zhenglei-BCS
Copy link
Collaborator

I can confirm that it can be successfully installed under R 4.3.3
image

@Zhenglei-BCS Zhenglei-BCS merged commit e250fe5 into main Oct 2, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Package Development Oct 2, 2025
@Zhenglei-BCS
Copy link
Collaborator

Zhenglei-BCS commented Oct 2, 2025

@Zhenglei-BCS Thanks, let me know if it works and then I'll merge this PR

I merged this directly after I confirmed it.

Zhenglei-BCS added a commit that referenced this pull request Oct 9, 2025
Make it more compatible with older packages
Zhenglei-BCS added a commit that referenced this pull request Oct 9, 2025
Make it more compatible with older packages
Zhenglei-BCS added a commit that referenced this pull request Oct 9, 2025
Make it more compatible with older packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants