Skip to content

Conversation

@orian
Copy link

@orian orian commented Mar 14, 2016

The app didn't built. I've upgraded to a new version of libraries and tools, it forced me to enable multiDex. Then I've encountered the 'duplicate entry for common.annotations.Beta' error. I've fixed it by modifying the build.gradle file.

@phajduk
Copy link
Owner

phajduk commented Mar 17, 2016

@orian according to Travis your changes make build to fail. Could you review changes?

@orian
Copy link
Author

orian commented Mar 17, 2016

I believe it's not possible to merge at this point. The Travis available version of libraries is older than the updated one. Can we make the PR wait for some time? I think someone may want to use it.

@phajduk
Copy link
Owner

phajduk commented Mar 18, 2016

Please squash commits and do a force push. I see that your changes in travis are OK so we need to launch new travis job to check the result.

…r common.annotations.Beta'.

Update versions in travis config.
@orian orian force-pushed the fix-duplicate-class branch from e6cc4e8 to 188805f Compare April 4, 2016 17:16
@orian
Copy link
Author

orian commented Apr 4, 2016

I've squashed commits. Sorry it took so long.

targetSdkVersion 23
versionCode 1
versionName "1.0"
multiDexEnabled true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we exceed 64k? 😱

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However crazy it sounds: debug mode + new version of dagger and appcompat was causing the app to miserably crash on Nexus 5 ;-) Googling revealed that the problem is 64k ;-)

I guess it should be possible to enable multidex in debug and disable in prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants