If we do need those options in the sub class, delete them we will have a problem#82
Open
facetothefate wants to merge 2 commits intophaethon:masterfrom
Open
If we do need those options in the sub class, delete them we will have a problem#82facetothefate wants to merge 2 commits intophaethon:masterfrom
facetothefate wants to merge 2 commits intophaethon:masterfrom
Conversation
…e problem See the DHCPv6_am, in the parse_options method, in there we need to know the interface information to compute the source ip address
Author
|
are there any special reasons for delete those options ? |
Using the class color
flokli
pushed a commit
to flokli/scapy
that referenced
this pull request
Nov 21, 2016
…n#137) Patch for the issue from pull request phaethon#82
flokli
pushed a commit
to flokli/scapy
that referenced
this pull request
Nov 21, 2016
Packet.getlayer() method can work with string layer name
Owner
|
If you can test and confirm that this works, there is no problem to return these options. Must have been some reason for commenting out though at the time of porting, but nobody would recall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#81
See the DHCPv6_am, in the parse_options method, in there we need to know
the interface information to compute the source ip address