Open
Conversation
pgomulka
commented
Jan 30, 2020
| if (i + 1 < length && pattern.charAt(i + 1) == '\'') { | ||
| // '' is treated as escaped ' | ||
| i++; | ||
| buf.append(c);//THIS IS THE CHANGE COMPARED TO JODA |
Owner
Author
There was a problem hiding this comment.
the only change needed in joda's DateTimeFormat
pgomulka
commented
Feb 5, 2020
| import org.joda.time.format.DateTimeFormatterBuilder; | ||
| import org.joda.time.format.ISODateTimeFormat; | ||
|
|
||
| public class CustomDateTimeFormat { |
Owner
Author
There was a problem hiding this comment.
copy of required methods from DateTimeFormat (unable to extend)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a PoC of auto migrating joda style patterns to java.time
It is basing on joda code responsible for parsing patterns, but instead of populating fields in DateFormatBuilder it appends translated letters into a new pattern.
This had to be a copy paste, as it required modifying (slightly though) methods that were private in joda.