Skip to content

Conversation

@evan-greenbrg
Copy link

Here are the updates for the build_lut scripts with all of the hooks working with Isofit 3. It may need another pair of eyes to validate that the configs generated have all of the necessary components.

This also includes a new flag in the cli to make the grid via a sobel sequence. I tried the match the Julia code from the Sobel branch. The regular and Sobel grids used are still hard coded into the python script. The regular grid is the same as what is on the original branch. The Sobel grid is smaller (from my testing)

In the Sobel grid generation, I've made it possible to generate different lengths of lut elements. This should be pretty self-explanatory in the code.

So far I haven't done too much rigorous testing.

  • I have only run locally to confirm that the correct number of files are generated. I was having some issues this weekend where only one worker was saving the files. I just re-ran today and couldn't replicate this issue.
  • It needs to be run on the cluster to confirm.
  • I also haven't run the generated config files through modtran/6s to confirm that they work properly.

This will also need a PR on Isofit to go through to run properly. I'll attempt to link the two.

@pgbrodrick pgbrodrick mentioned this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants