Skip to content

Build musllinux wheels in CI #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrMino wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build musllinux wheels in CI #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,16 @@ jobs:
- 'manylinux1_x86_64'
- 'manylinux1_i686'
- 'manylinux2014_aarch64'
- 'musllinux_1_1_x86_64'
- 'musllinux_1_1_i686'
- 'musllinux_1_1_aarch64'
name: Build a ${{ matrix.platform }} for ${{ matrix.python_tag }}
steps:
- uses: actions/checkout@v3
- uses: docker/setup-qemu-action@v2
if: ${{ matrix.platform == 'manylinux2014_aarch64' }}
if: |
matrix.platform == 'manylinux2014_aarch64' ||
matrix.platfrom == 'musllinux_1_1_aarch64'
Copy link
Author

@MrMino MrMino Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure about this. Why do we need Qemu for aarch64? I thought auditwheel can handle arch without emulation?

Copy link
Owner

@pganssle pganssle Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it can now but it couldn't in 2019 or 2020? I doubt that I had a deep understanding of what I was doing when I put this together.

Copy link
Author

@MrMino MrMino Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try and check, removing this would speed up CI.

name: Set up QEMU
- name: Install docker image
run: |
Expand Down