Skip to content

"Added my name to contributors – Mayur"#494

Open
mayurgalhate wants to merge 3 commits intopgRouting:mainfrom
mayurgalhate:mayur-test
Open

"Added my name to contributors – Mayur"#494
mayurgalhate wants to merge 3 commits intopgRouting:mainfrom
mayurgalhate:mayur-test

Conversation

@mayurgalhate
Copy link

@mayurgalhate mayurgalhate commented Dec 8, 2025

Fixes # .

Changes proposed in this pull request:

@pgRouting/admins

Summary by CodeRabbit

  • Chores

    • Improved release process to compose a full version string that includes development suffixes for more precise build/version tracking.
  • Documentation

    • Updated release documentation and translation metadata to add a contributor (Mayur Galhate) and refresh POT timestamps.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Walkthrough

Compute a FULL_VERSION in the release workflow by reading a development version from CMakeLists.txt and concatenating it with the base pgRouting version; add Mayur Galhate to the contributors list in the pgRouting introduction and updated POT/PO metadata timestamps.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/release.yml
Reads PROJECT_VERSION_DEV from CMakeLists.txt into PGROUTING_VERSION_DEV and defines FULL_VERSION by concatenating PGROUTING_VERSION and PGROUTING_VERSION_DEV. PGROUTING_VERSION remains used for env exports and tag naming in the shown steps.
Documentation (introduction)
doc/src/pgRouting-introduction.rst
Inserts "Mayur Galhate" into the "Individuals in this release (alphabetical order)" contributors list.
Localization (PO/POT)
locale/en/LC_MESSAGES/pgrouting_doc_strings.po, locale/pot/pgrouting_doc_strings.pot
Updated POT-Creation-Date timestamp and added "Mayur Galhate" to the release contributors entry; minor line-wrapping changes in the PO strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check intended use of the newly computed FULL_VERSION in the workflow (currently computed but unused in shown steps).
  • Confirm the exact spelling and alphabetical placement of "Mayur Galhate" across docs and localization files.
  • Verify PO/POT timestamp updates are intentional and consistent with release processes.

Poem

🐰 I stitched a version, tiny and spry,
Read a dev number from CMake on high,
Names hop into lists, ordered and neat,
Contributors gather — paws tap the beat. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the pull request: adding the author's name to the contributor lists across multiple documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)

8329-8331: Contributor list update looks correct; consider fixing a capitalization nit

Adding “Mayur Galhate” maintains alphabetical order and the line split is valid for a PO msgid. One small consistency point: “Saloni kumari” here uses a lowercase “k”, while elsewhere in this file the same name appears as “Saloni Kumari”; you may want to standardize the capitalization.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80adc7a and 884d80f.

📒 Files selected for processing (2)
  • locale/en/LC_MESSAGES/pgrouting_doc_strings.po (2 hunks)
  • locale/pot/pgrouting_doc_strings.pot (2 hunks)
🔇 Additional comments (3)
locale/pot/pgrouting_doc_strings.pot (2)

11-11: POT creation timestamp update is appropriate

The updated POT-Creation-Date reflects a regenerated template and is consistent with normal i18n workflow.


7147-7151: Contributor string correctly updated and ordered

Adding “Mayur Galhate” to the “Individuals in this release” list keeps the names in alphabetical order by first name and matches the documented intent of the section.

locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)

11-11: POT-Creation-Date update is fine

Timestamp change is consistent with regenerated message catalog metadata; no further action needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants