"Added my name to contributors – Mayur"#494
"Added my name to contributors – Mayur"#494mayurgalhate wants to merge 3 commits intopgRouting:mainfrom
Conversation
WalkthroughCompute a FULL_VERSION in the release workflow by reading a development version from CMakeLists.txt and concatenating it with the base pgRouting version; add Mayur Galhate to the contributors list in the pgRouting introduction and updated POT/PO metadata timestamps. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)
8329-8331: Contributor list update looks correct; consider fixing a capitalization nitAdding “Mayur Galhate” maintains alphabetical order and the line split is valid for a PO msgid. One small consistency point: “Saloni kumari” here uses a lowercase “k”, while elsewhere in this file the same name appears as “Saloni Kumari”; you may want to standardize the capitalization.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
locale/en/LC_MESSAGES/pgrouting_doc_strings.po(2 hunks)locale/pot/pgrouting_doc_strings.pot(2 hunks)
🔇 Additional comments (3)
locale/pot/pgrouting_doc_strings.pot (2)
11-11: POT creation timestamp update is appropriateThe updated
POT-Creation-Datereflects a regenerated template and is consistent with normal i18n workflow.
7147-7151: Contributor string correctly updated and orderedAdding “Mayur Galhate” to the “Individuals in this release” list keeps the names in alphabetical order by first name and matches the documented intent of the section.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)
11-11: POT-Creation-Date update is fineTimestamp change is consistent with regenerated message catalog metadata; no further action needed.
Fixes # .
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.