feat: check crew profile in partyroom#252
Open
YoonJongok wants to merge 13 commits intodevelopmentfrom
Open
Conversation
Extract profile component to apply to viewCrewProfile and EditProfileBio
|
@YoonJongok is attempting to deploy a commit to the PFPlay team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
YoonJongok
changed the title
YoonJongok
changed the title
will-kim-querypie
changed the title
will-kim-querypie
requested changes
Feb 26, 2025
Comment on lines
+5
to
+6
| import { Avatar } from '@/entities/avatar'; | ||
| import { Profile } from '@/entities/profile'; |
Contributor
There was a problem hiding this comment.
[변경요청]
의존성 방향이 역전됐습니다 shared -> entities
src/shared/api/http/types/crews.ts
Outdated
Comment on lines
+22
to
+25
| export type CrewProfile = ProfileSummary & { | ||
| crewId: number; | ||
| registrationDate?: string; | ||
| }; |
Contributor
There was a problem hiding this comment.
[질문]
백단 dto에서 실제로 ProfileSummary라는 공통 필드 모음 dto 클래스를 따로 빼고 이를 확장하는 방식으로 사용하고 있나요? 아니면 그냥 중복되는 필드들이 보이니 ProfileSummary 라는 이름의 인터페이스로 분기하신 걸까요?
후자라면 인터페이스 확장 제거하고 각 dto를 따로 냅두는게 좋을 것 같습니다. 공용이라 생각하고 분리한게 사실 공용이 아닌 경우가 많더라구요.
Contributor
Author
There was a problem hiding this comment.
후자였습니다. 확장 제거하고 각 dto 따로 두겠습니다!
Comment on lines
+4
to
+23
| export type Model = { | ||
| avatarBodyUri: string; | ||
| avatarFaceUri: string; | ||
| combinePositionX: number; | ||
| combinePositionY: number; | ||
| nickname: string; | ||
| introduction: string; | ||
| score: number; | ||
| registrationDate: string; | ||
| }; | ||
|
|
||
| export const score = (activitySummaries: ActivitySummary[], activityType: ActivityType): number => { | ||
| const summary = activitySummaries.find((summary) => summary.activityType === activityType); | ||
|
|
||
| return summary ? summary.score : 0; | ||
| }; | ||
|
|
||
| export const registrationDate = (registrationDate: string): string => { | ||
| return registrationDate.replace(/-/g, '.'); | ||
| }; |
Contributor
There was a problem hiding this comment.
[변경요청]
- 모델의 score와 computed score가 공존하고 있습니다.
- computed score가 인자로 받는 값들은 이 모델이 가지고 있는 값이 아닙니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
채팅 방에 다른 유저의 프로필 사진을 눌렀을 시 해당 유저의 프로필 정보를 볼 수 있습니다.
Todo
crew 정보 api에서 registrationDate가 추가되어야 합니다. 추가 확인 후 view-crew-profile.component.tsx: line 28의 nullish coalescing(??)을 제거해야 합니다.
Issue
N/A
Reference
N/A