Permissions are now changed for custom appImages#41
Open
pakeke-constructor wants to merge 1 commit intopfirsich:masterfrom
Open
Permissions are now changed for custom appImages#41pakeke-constructor wants to merge 1 commit intopfirsich:masterfrom
pakeke-constructor wants to merge 1 commit intopfirsich:masterfrom
Conversation
Owner
|
There is a chance that the we don't have permission to add the executable bit on the custom AppImage in which case this might break for some people. This is probably (like 95%) fine, but could you add a check that the executable bit is not already set? I'd probably do |
Author
|
Yup! sure thing. Good catch btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if you had a custom appImage, the execute permission wasn't set on your AppImage.
This PR changes/fixes that